Viewing 9 posts - 1 through 9 (of 9 total)
  • Author
    Posts
  • #585
    Darwin
    Participant

    Hi, nice plugin, thanks for your work.

    I was having an issue where images that were set to link to the attachment page were still getting processed by the plugin, but the loading spinner would sit there indefinitely since it can’t load a page in the lightbox. The problem is a bug in the regex:

    Changing line 148 from:

    preg_match_all('/<a(.*?)href=(?:\'|")(.*?).(bmp|gif|jpeg|jpg|png)(?:\'|")(.*?)>/i', $content, $links);

    to:

    preg_match_all('/<a(.*?)href=(?:\'|")([^<]*?).(bmp|gif|jpeg|jpg|png)(?:\'|")(.*?)>/i', $content, $links);

    …will fix the issue, which happens because one of the open-ended “(.*?)” wildcards will match all the way up to the img tag inside the a-tag, and thinks that entire string is the link.

    Hope this helps someone else. :)

    #587
    james ebeling
    Participant

    Fantastic, great fix Darwin Campa! I was having the same issue on my Laptop. Funny that it still worked on iOS devices. Thanks again for troubleshooting this for everyone.

    JIMMYCSS

    #588
    james ebeling
    Participant

    Actually, no it’s not working for me, and I am getting the loading icon again…

    here is the page: http://jamesebeling.com/testing/jamesebeling/me/

    Thanks,
    JIMMYCSS

    #589
    Darwin
    Participant

    Did you figure it out? Your page seems to work for me, I don’t get any loading spinners.

    #590
    james ebeling
    Participant

    It works great in Firefox and Safari, but does not work in Chrome when I’m on my MacBook Pro.

    When I am on my phone it works great in any browser.

    #591
    Bartosz
    Keymaster

    Awesome!

    We’ll release an update shortly.

    #598
    james ebeling
    Participant

    I just updated the plugin and still having the issue in Chrome on a Mac Computer???

    http://jamesebeling.com/testing/jamesebeling/me/

    #599
    Bartosz
    Keymaster

    Your site works for me in Chrome on Windows, should behave the same on Mac.

    #600
    Darwin
    Participant

    I’m using Chrome on a Mac and it works fine.

Viewing 9 posts - 1 through 9 (of 9 total)
  • You must be logged in to reply to this topic.